[Build] Refactor more code to adhere to stricter build warnings#444
[Build] Refactor more code to adhere to stricter build warnings#444VivekPanyam wants to merge 1 commit intomultiprocess_cc_warningsfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## multiprocess_cc_warnings #444 +/- ##
=========================================================
Coverage 88.23% 88.23%
=========================================================
Files 102 102
Lines 6356 6358 +2
=========================================================
+ Hits 5608 5610 +2
Misses 748 748 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| { | ||
|
|
||
| std::string get_cwd() | ||
| static std::string get_cwd() |
There was a problem hiding this comment.
asked already about static in other review
There was a problem hiding this comment.
maybe anonymous namespace instead of detail will work here instead of "static"
| void serialize(boost::archive::binary_oarchive &out, const NeuropodValueMap &item) | ||
| { | ||
| int num_items = item.size(); | ||
| auto num_items = static_cast<int>(item.size()); |
There was a problem hiding this comment.
is it supposed to be int here? Or this is for backward compatibility with existing models? Maybe "unsigned int" can be used in this case (but need to keep it in sync with deserialize?
Anyway, if you decide to use int, consider using boost::numeric_cast, this is for safe conversion in case like this one
vkuzmin-uber
left a comment
vkuzmin-uber
left a comment
There was a problem hiding this comment.
Looks good. One comment about serialization, please check
3 participants
Summary:
Refactor additional code (mostly under
source/neuropod/bindings) to adhere to the stricter set of warnings introduced in #437Test Plan:
CI