Add a support of a weak instance with the identity.#452
Open
ryu1sazae wants to merge 2 commits intouber:masterfrom
Open
Add a support of a weak instance with the identity.#452ryu1sazae wants to merge 2 commits intouber:masterfrom
ryu1sazae wants to merge 2 commits intouber:masterfrom
Conversation
ryu1sazae
force-pushed
the
ryu1sazae/support-shared-identifier
branch
from
3a5fdd1 to
8375428
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes, we want to choose whether to share same ViewModel among different instances of View as long as the ViewModel's instance has been referenced somewhere. Like that, it is better to be able to choose without adding another definition for some situations I suppose.
We can use
weakconstructor I just added in this PR for such purpose.