Open
Conversation
Collaborator
rudro
commented
Nov 13, 2020
rudro
commented
- These methods are one-liners of the form "return dependency.propertyName"
- These methods are one-liners of the form "return dependency.propertyName"
tianskylan
approved these changes
Nov 13, 2020
Contributor
tianskylan
left a comment
tianskylan
left a comment
There was a problem hiding this comment.
Could you add a unit test for this? Should be pretty straightforward
| if let block = pattern.children.first(where: { $0.is(CodeBlockSyntax.self) }), let fullBody = block.as(CodeBlockSyntax.self) { | ||
| // Make sure that the code block is a one-liner | ||
| if let statement = fullBody.statements.first, fullBody.statements.count == 1 { | ||
| let trimmed = statement.description.trimmingCharacters(in: .whitespacesAndNewlines) |
Contributor
There was a problem hiding this comment.
I've added a trimmed convenience method for this. You can do .description.trimmed directly
balavor
reviewed
May 6, 2021
| // Make sure that the code block is a one-liner | ||
| if let statement = fullBody.statements.first, fullBody.statements.count == 1 { | ||
| let trimmed = statement.description.trimmingCharacters(in: .whitespacesAndNewlines) | ||
| let lookFor1 = "return dependency.\(propertyName)" |
Contributor
There was a problem hiding this comment.
trimmed will never be equal to lookFor1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.