This repository was archived by the owner on Sep 25, 2020. It is now read-only.
Emit server-added and server-removed stat on ringChanged event#281
Open
btromanova wants to merge 1 commit intomasterfrom
Open
Emit server-added and server-removed stat on ringChanged event#281btromanova wants to merge 1 commit intomasterfrom
btromanova wants to merge 1 commit intomasterfrom
Conversation
btromanova
force-pushed
the
tr-fix-ringchanged-stats
branch
from
449af31 to
ed22ffc
Compare
Contributor
Author
|
Similar logic in go: https://github.com/uber/ringpop-go/blob/dev/ringpop.go#L509 Versions will still be not in sync in emitting events after this change, because node version emits ringServerAdded events on hashring.addServer (same for remove) and go version emits RingChangedEvent. But I think it's a separate issue and can be fixed later. |
Contributor
|
LGTM, can you add tests for this though? |
Contributor
|
Looks good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stat is emitted on ringChange in go-version, need to keep node version in-sync.