This repository was archived by the owner on Sep 25, 2020. It is now read-only.
Open
Conversation
|
|
rf
suggested changes
Dec 20, 2016
| throw new Error("endpoints must be an array"); | ||
| } | ||
| this.http = http; | ||
| this.protocol = protocol; |
Contributor
There was a problem hiding this comment.
nit: property name http is more clearly a module to me than protocol which sounds like it is going to be a string "http" or "https"
| var port = +ip_port[1]; | ||
| if (port > 0 && port < 65536) { | ||
| var endpoint = new GO.PoolEndpoint(this.http, ip, port, this.options); | ||
| var endpoint = new GO.PoolEndpoint(this.protocol, ip, port, this.options); |
Contributor
There was a problem hiding this comment.
it seems like you intended for agent to be a property of options but I don't see that anywhere
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the keepalive agent indexes sockets on a host:port basis, there is no need to create a keepalive agent per pool endpoint. This diff creates a keepalive agent on the pool and passes it into the pool_endpoint on creation.
cc: @rf @Raynos