Skip to content

Always close transport to prevent resource leak #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
justinjc wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Always close transport to prevent resource leak #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions core/src/main/java/com/uber/m3/tally/ScopeBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,11 @@ public Scope reportEvery(Duration interval) {
public Scope reportEvery(Duration interval,
Thread.UncaughtExceptionHandler uncaughtExceptionHandler) {
if (interval.compareTo(Duration.ZERO) <= 0) {
if (reporter != null) {
// The underlying transport in the reporter may have been opened at this point, so make sure to close
// that to not leak resources.
reporter.close();
}
throw new IllegalArgumentException("Reporting interval must be a positive Duration");
}

Expand Down
3 changes: 3 additions & 0 deletions m3/src/main/java/com/uber/m3/tally/m3/M3Reporter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,9 @@ private M3Reporter(Builder builder) {

addAndRunProcessor(builder.metricTagSet);
} catch (TTransportException | SocketException e) {
if (transport != null) {
transport.close();
}
throw new RuntimeException("Exception creating M3Reporter", e);
}
}
Expand Down