Skip to content

Conversation

@joelmarty
Copy link

Fixes #105

Changes

  • Bump com.datadoghq:java-dogstatsd-client to 4.0.0
  • Pass tags to the statsd client instead of ignoring them
  • Fix tests:
    • Move the StatsdAssertingUdpServer to the test sources
    • Expose the lines failing assertion: since the StatsdAssertingUdpServer runs in another thread, the exception was not picked up by JUnit and the test passed anyway.
    • Test the passed tags, which required to review the implementation and parse back the received metrics: the previous implementation ignored everything after the type field in the metric line.

@CLAassistant
Copy link

CLAassistant commented Apr 21, 2022

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

StatsdReporter does not support tags

2 participants