[Android] Fix zlib fdopen macro breaking macOS builds#39
Closed
azad-uber-2 wants to merge 1 commit into
Closed
Conversation
On modern macOS, TARGET_OS_MAC is always 1 (set by system headers), causing `#define fdopen(fd,mode) NULL` to fire. This macro replaces the fdopen token everywhere, which breaks when the macOS SDK's _stdio.h declares `FILE *fdopen(int, const char *)` — the compiler sees `FILE *NULL(int, const char *)` and errors out. The #else branch was written for classic Mac OS (pre-OS X) using non-Metrowerks compilers that no longer exist. Modern macOS provides fdopen via the system and needs no macro. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On modern macOS,
TARGET_OS_MACis always 1 (set by system headers), causing#define fdopen(fd,mode) NULLto fire inthird_party/zlib/zutil.h. This macro replaces thefdopentoken everywhere, which breaks when the macOS SDK's_stdio.hdeclaresFILE *fdopen(int, const char *)— the compiler seesFILE *NULL(int, const char *)and errors out.The removed
#elsebranch was written for classic Mac OS (pre-OS X) using non-Metrowerks compilers that no longer exist. Modern macOS providesfdopenvia the system and needs no macro.Test plan
fdopenredefinition error)🤖 Generated with Claude Code
Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com