Preserve scale and offset when processing las file#33
Merged
pierotofy merged 3 commits intouav4geo:mainfrom Aug 23, 2025
Merged
Preserve scale and offset when processing las file#33pierotofy merged 3 commits intouav4geo:mainfrom
pierotofy merged 3 commits intouav4geo:mainfrom
Conversation
Member
|
Hey thanks for the PR. Can you please make sure:
|
2. prevent edge cases when offsets or scales not exist
Contributor
Author
|
Hi @pierotofy, I used the same default value being defined in pdal's writer.las so the outcome would be the same. But you are right, better to let pdal decides what the default value it would use. I updated the PR as requested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
When reading and write las/laz, the original scale and offset stored in the input file is lost, and the output will use the default value of them, which results in a loss in precision when the original data's precision is higher than 0.01m. This PR attempts to preserve the original offset/scale in the output las/laz file.
This PR added two extra member variables for the internal point cloud data structure to store scale and offset. If the input is las file, the scale and offset in metadata will be stored. If the output is las file, the scale and offset will be used to in the output las file.