Skip to content

fix issue: cannot deselect index (when call [setSelectedSegmentIndex:-1]... #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nowsprinting wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix issue: cannot deselect index (when call [setSelectedSegmentIndex:-1]... #7

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
83a288f
fix issue: cannot deselect index (when call [setSelectedSegmentIndex:…
nowsprinting Mar 3, 2013
e96079d
fix illegally value-changed event, when tap disabled segment
nowsprinting Mar 9, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions URBSegmentedControl.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,7 @@ - (id)initWithTitles:(NSArray *)titles icons:(NSArray *)icons {
}

- (id)initWithCoder:(NSCoder *)aDecoder {
_selectedSegmentIndex = -1;
self = [super initWithCoder:aDecoder];
if (self) {
CGRect nibFrame = self.frame;
Expand Down Expand Up @@ -317,6 +318,7 @@ - (NSUInteger)numberOfSegments {
}

- (void)setEnabled:(BOOL)enabled forSegmentAtIndex:(NSUInteger)segment {
[super setEnabled:enabled forSegmentAtIndex:segment];
[self segmentAtIndex:segment].enabled = enabled;
}

Expand All @@ -326,13 +328,14 @@ - (BOOL)isEnabledForSegmentAtIndex:(NSUInteger)segment {

- (void)setSelectedSegmentIndex:(NSInteger)selectedSegmentIndex {
if (_selectedSegmentIndex != selectedSegmentIndex) {
NSParameterAssert(selectedSegmentIndex < (NSInteger)self.items.count && selectedSegmentIndex >= 0);
NSParameterAssert(selectedSegmentIndex < (NSInteger)self.items.count);

// deselect current segment if selected
if (_selectedSegmentIndex >= 0)
((URBSegmentView *)[self segmentAtIndex:_selectedSegmentIndex]).selected = NO;

[self segmentAtIndex:selectedSegmentIndex].selected = YES;
if (selectedSegmentIndex >= 0)
((URBSegmentView *)[self segmentAtIndex:selectedSegmentIndex]).selected = YES;

_lastSelectedSegmentIndex = _selectedSegmentIndex;
_selectedSegmentIndex = selectedSegmentIndex;
Expand Down