Make websocket headers case insensitive, better cookie header handling #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evanbsmith
commented
Jul 26, 2016
evanbsmith
commented
- Per Websocket/HTTP spec, updated to allow case-insensitivity in websocket/HTTP headers
- Updated "set-cookie" header to allow for multiple cookie values, saving first one as sid
- Add debug code to print client websocket request headers
Per Websocket/HTTP spec, updated to allow case-insensitivity in websocket/HTTP headers.
lhovo
reviewed
Aug 21, 2018
|
Using this code for the case-insensitivity, it's working well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.