Improve motor demo#144
Conversation
simulation is more responsive and comments to remind future me what's going on.
| private static void nearCallback (Object data, DGeom o1, DGeom o2) | ||
| { | ||
| private void nearCallback (Object data, DGeom o1, DGeom o2) { | ||
| // exit without doing anything if the two bodies are connected by a joint |
There was a problem hiding this comment.
This comment is misleading. Was it supposed to be a TODO?
There was a problem hiding this comment.
The comment is not from me. I will have a look.
|
Hi @i-make-robots, thanks a lot for the PR! As I understand, this is a purely cosmetic PR, correct? Unfortunately, there is a problem, I usually do not accept cosmetic changes to ode4j. I know that the look of the code makes your toenails curl up, but there is a reason I keep it this way. ode4j is an ongoing port of ODE C++. Every bit of rearranging/adding/removing of the Java code makes it harder for all following iterations when I port the latest changes. The fact that this is a demo (which is looked at by users) means that I may actually adopt some changes, but it is likely only a small subset of what you propose. I will have a look. Sorry about that. I really do appreciate the effort though. |
2 participants
nearcallbackwith lambda and removed some other redundancies