fix(editor): use platform-aware Shift modifier in empty-state shortcut hint#20
Merged
Merged
Conversation
bet4it
force-pushed
the
fix/editor-shift-key-hint
branch
from
c639290 to
013b0c1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On non-Mac platforms, the empty-state shortcut hint in
EditorAreawas rendering⇧Ctrl+F— mixing the Mac-specific⇧symbol with the Windows/LinuxCtrl+text.Root cause: The
⇧was hard-coded, while the adjacentmodKeyvariable was already platform-aware.Fix: Introduce a parallel
shiftKeyvariable (same pattern asmodKey) and use it in the hint:⌘⇧FCtrl+Shift+F(Ctrl before Shift, matching mainstream convention)