Create files for Simple#106
Open
hello-world-404 wants to merge 7 commits intotypora:gh-pagesfrom
hello-world-404:gh-pages
Open
Create files for Simple#106hello-world-404 wants to merge 7 commits intotypora:gh-pagesfrom hello-world-404:gh-pages
hello-world-404 wants to merge 7 commits intotypora:gh-pagesfrom
hello-world-404:gh-pages
Conversation
Contributor
|
@One-Kingyo Could you add the thumb file and screenshot? |
Author
|
Sure, I could add the screenshot, but I'm not quite sure what the thumb file is. |
Author
|
I've added the thumbnail and the screenshot, and waiting to push. |
abnerlee
reviewed
Apr 4, 2020
_posts/fork/2020-3-25-Simple.md
Outdated
| --- | ||
| layout: theme | ||
| title: Simple | ||
| category: fork |
Contributor
There was a problem hiding this comment.
This is theme a "fork" of an existing theme? If not, the category should be "theme"
Contributor
thumb file is the image you can see in the index of https://theme.typora.io/ for each theme |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's my first time here. I created a theme based on the typora template and I would like to submit it. I am doing my best to follow the instructions written on the submit page, and can somebody tell me if I am doing this the right way?