Annotate Java Beans property listeners for nullness#123
Open
grv87 wants to merge 5 commits intotypetools:masterfrom
Open
Annotate Java Beans property listeners for nullness#123grv87 wants to merge 5 commits intotypetools:masterfrom
grv87 wants to merge 5 commits intotypetools:masterfrom
Conversation
Member
|
Thank you for these annotations! We appreciate it. Overall they look great. Your comment about I have a couple questions:
Finally, a few minor notes:
|
Member
|
@grv87 A ping regarding the two comments I had on this pull request. Thanks again for the annotations. |
Member
|
@grv87 Another ping. I would like to get this pull request merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added
@Nullablefor several classes injava.beanspackage.I'm not sure about
propertyNameproperty inIndexedPropertyChangeEvent.According to the class' javadoc, it can be null.
But:
PropertyChangeEvent, maybe a typo in JDKpropertyName, but withindexNote that this property corresponds to
propertyNamearg inPropertyChangeSupport#fireIndexedPropertyChange. I added missing@Nullables infirePropertyChangemethods, but not infireIndexedPropertyChange.