-
Notifications
You must be signed in to change notification settings - Fork 437
Add Resource Leak Checker tests for JDBC and RowSet resource types #7480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
b29cbe5
68905ac
5ca2cf8
9d2816e
76273bd
235fc12
87f4485
c431545
ac2c32e
e9015cb
87c99d2
d0e7c3f
2759b85
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,68 @@ | ||
| // Tests for JDBC types resource leak detection | ||
| // Test case for issue 6354: | ||
| // https://github.com/typetools/checker-framework/issues/6354 | ||
|
|
||
| import java.sql.*; | ||
|
|
||
| class JdbcResourceLeak { | ||
|
|
||
| // ========== ResultSet Tests ========== | ||
|
|
||
| void resultSetNotClosed(Statement stmt) throws SQLException { | ||
| ResultSet rs = stmt.executeQuery("SELECT 1"); | ||
| // :: error: [required.method.not.called] | ||
| } | ||
|
|
||
| void resultSetClosed(Statement stmt) throws SQLException { | ||
| ResultSet rs = stmt.executeQuery("SELECT 1"); | ||
| rs.close(); | ||
| } | ||
|
|
||
| // ========== Statement Tests ========== | ||
|
|
||
| void statementNotClosed(Connection conn) throws SQLException { | ||
| Statement stmt = conn.createStatement(); | ||
| // :: error: [required.method.not.called] | ||
| } | ||
|
|
||
| void statementClosed(Connection conn) throws SQLException { | ||
| Statement stmt = conn.createStatement(); | ||
| stmt.close(); | ||
| } | ||
|
|
||
| // ========== PreparedStatement Tests ========== | ||
|
|
||
| void preparedStatementNotClosed(Connection conn) throws SQLException { | ||
| PreparedStatement ps = conn.prepareStatement("SELECT ?"); | ||
| // :: error: [required.method.not.called] | ||
| } | ||
|
|
||
| void preparedStatementClosed(Connection conn) throws SQLException { | ||
| PreparedStatement ps = conn.prepareStatement("SELECT ?"); | ||
| ps.close(); | ||
| } | ||
|
|
||
| // ========== Nested Resources ========== | ||
|
|
||
| void nestedBothClosed(Connection conn) throws SQLException { | ||
| Statement stmt = conn.createStatement(); | ||
| ResultSet rs = stmt.executeQuery("SELECT 1"); | ||
| rs.close(); | ||
| stmt.close(); | ||
| } | ||
|
|
||
| void nestedStatementNotClosed(Connection conn) throws SQLException { | ||
| Statement stmt = conn.createStatement(); | ||
| ResultSet rs = stmt.executeQuery("SELECT 1"); | ||
| rs.close(); | ||
| // :: error: [required.method.not.called] | ||
| } | ||
coderabbitai[bot] marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| void nestedResultSetNotClosed(Connection conn) throws SQLException { | ||
| Statement stmt = conn.createStatement(); | ||
| ResultSet rs = stmt.executeQuery("SELECT 1"); | ||
| stmt.close(); | ||
| // :: error: [required.method.not.called] | ||
| } | ||
|
|
||
| } | ||
| Original file line number | Diff line number | Diff line change | ||
|---|---|---|---|---|
| @@ -0,0 +1,91 @@ | ||||
| // Tests for RowSet types resource leak detection | ||||
| // Test case for issue 6354: | ||||
| // https://github.com/typetools/checker-framework/issues/6354 | ||||
|
|
||||
| import javax.sql.rowset.*; | ||||
| import com.sun.rowset.*; | ||||
| import java.sql.*; | ||||
|
|
||||
| class RowSetResourceLeak { | ||||
|
|
||||
| // ========== JdbcRowSet Tests ========== | ||||
|
|
||||
| void jdbcRowSetNotClosed(ResultSet rs) throws SQLException { | ||||
| JdbcRowSet jrs = new JdbcRowSetImpl(rs); | ||||
| // :: error: [required.method.not.called] | ||||
| } | ||||
|
|
||||
| void jdbcRowSetClosed(ResultSet rs) throws SQLException { | ||||
| JdbcRowSet jrs = new JdbcRowSetImpl(rs); | ||||
| jrs.close(); | ||||
| } | ||||
|
|
||||
| // ========== CachedRowSet Tests ========== | ||||
|
|
||||
| void cachedRowSetNotClosed() throws SQLException { | ||||
| CachedRowSet crs = new CachedRowSetImpl(); | ||||
| // :: error: [required.method.not.called] | ||||
| } | ||||
|
|
||||
| void cachedRowSetClosed() throws SQLException { | ||||
| CachedRowSet crs = new CachedRowSetImpl(); | ||||
| crs.close(); | ||||
| } | ||||
|
|
||||
| void cachedRowSetToResultSetNotClosed() throws SQLException { | ||||
| CachedRowSet crs = new CachedRowSetImpl(); | ||||
| ResultSet rs = crs.toResultSet(); | ||||
| crs.close(); | ||||
| // :: error: [required.method.not.called] | ||||
| } | ||||
coderabbitai[bot] marked this conversation as resolved.
Show resolved
Hide resolved
|
||||
|
|
||||
| void cachedRowSetToResultSetBothClosed() throws SQLException { | ||||
| CachedRowSet crs = new CachedRowSetImpl(); | ||||
| ResultSet rs = crs.toResultSet(); | ||||
| rs.close(); | ||||
| crs.close(); | ||||
| } | ||||
coderabbitai[bot] marked this conversation as resolved.
Show resolved
Hide resolved
coderabbitai[bot] marked this conversation as resolved.
Show resolved
Hide resolved
|
||||
|
|
||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧹 Nitpick | 🔵 Trivial Nit: trailing whitespace on blank line. Line 48 contains trailing spaces. Trim to a clean blank line for consistency. -
+📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||
| void cachedRowSetToResultSetBothNotClosed() throws SQLException { | ||||
| CachedRowSet crs = new CachedRowSetImpl(); | ||||
| ResultSet rs = crs.toResultSet(); | ||||
| // :: error: [required.method.not.called] | ||||
| // :: error: [required.method.not.called] | ||||
| } | ||||
|
|
||||
| // ========== FilteredRowSet Tests ========== | ||||
|
|
||||
| void filteredRowSetNotClosed() throws SQLException { | ||||
| FilteredRowSet frs = new FilteredRowSetImpl(); | ||||
| // :: error: [required.method.not.called] | ||||
| } | ||||
|
|
||||
| void filteredRowSetClosed() throws SQLException { | ||||
| FilteredRowSet frs = new FilteredRowSetImpl(); | ||||
| frs.close(); | ||||
| } | ||||
|
|
||||
| // ========== WebRowSet Tests ========== | ||||
|
|
||||
| void webRowSetNotClosed() throws SQLException { | ||||
| WebRowSet wrs = new WebRowSetImpl(); | ||||
| // :: error: [required.method.not.called] | ||||
| } | ||||
|
|
||||
| void webRowSetClosed() throws SQLException { | ||||
| WebRowSet wrs = new WebRowSetImpl(); | ||||
| wrs.close(); | ||||
| } | ||||
|
|
||||
| // ========== JoinRowSet Tests ========== | ||||
|
|
||||
| void joinRowSetNotClosed() throws SQLException { | ||||
| JoinRowSet jrs = new JoinRowSetImpl(); | ||||
| // :: error: [required.method.not.called] | ||||
| } | ||||
|
|
||||
| void joinRowSetClosed() throws SQLException { | ||||
| JoinRowSet jrs = new JoinRowSetImpl(); | ||||
| jrs.close(); | ||||
| } | ||||
| } | ||||
Uh oh!
There was an error while loading. Please reload this page.