Open
Conversation
Multiple bind commands for the same hotkey now stack into a sequence that executes all commands in order. This allows users to create complex keybindings by chaining multiple actions together. Usage: yashiki bind alt-x window-close yashiki bind alt-x tag-view 2 yashiki bind alt-x retile # alt-x now executes all three commands in order Implementation: - Add Command::Sequence variant to yashiki-ipc - Update HotkeyManager::bind to create sequences automatically - Add sequence execution to process_command with fail-fast behavior - Add comprehensive tests for sequence creation and execution Features: - Commands execute in bind order - Each command sees state changes from previous commands - Sequence stops on first error (fail-fast) - Single unbind removes entire sequence - Backward compatible (no CLI changes)
nullun
force-pushed
the
feature/bind-sequences
branch
from
e02821b to
7506599
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multiple bind commands for the same hotkey now stack into a sequence that executes all commands in order. This allows users to create complex keybindings by chaining multiple actions together. Whilst I haven't fully tested the new keybinding mode system, there is a test that demonstrates separation of sequences in different modes.
Usage:
yashiki bind alt-shift-o output-send next
yashiki bind alt-shift-o output-focus next
# alt-shift-o now executes both commands in order
Implementation:
Features: