Add Google Cloud Events Pubsub & Storage#658
Open
Yummy-Yums wants to merge 16 commits into
Open
Conversation
| def data: String | ||
| def attributes: Map[String, String] | ||
| def messageId: String | ||
| def publishTime: String |
Contributor
Contributor
Author
There was a problem hiding this comment.
that's also protobuf generated. I'd use Instant just as @armanbilge suggested here
Chingles2404
requested changes
Jun 29, 2026
Chingles2404
requested changes
Jul 6, 2026
Chingles2404
left a comment
Chingles2404
left a comment
Contributor
There was a problem hiding this comment.
For StorageObjectData.scala, could you go through the fields and change the fields with "format": "date-time" in the JSON definition to Instant too?
Other than this, I think it looks great!
Chingles2404
approved these changes
Jul 8, 2026
Chingles2404
left a comment
Chingles2404
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me! Thanks for your work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Google Cloud Run Platform Events for Storage & Pubsub