Add AppSyncLambdaAuthorizer#642
Merged
Merged
Conversation
Contributor
Author
|
@armanbilge pleas review |
Yummy-Yums
changed the title
Chingles2404
approved these changes
Jun 22, 2026
Chingles2404
left a comment
Chingles2404
left a comment
Contributor
There was a problem hiding this comment.
Looks great! Thanks for your hard work!
armanbilge
requested changes
Jun 26, 2026
armanbilge
left a comment
armanbilge
left a comment
Member
There was a problem hiding this comment.
Looks good, noticed one thing!
armanbilge
requested changes
Jul 3, 2026
Comment on lines
+30
to
+34
| assertEquals(parsed_event.authorizationToken, "ExampleAUTHtoken123123123") | ||
| assertEquals(parsed_event.requestContext.accountId, "111122223333") | ||
| assertEquals(parsed_event.requestContext.apiId, "aaaaaa123123123example123") | ||
| assertEquals(parsed_event.requestContext.requestId, "f4081827-1111-4444-5555-5cf4695f339f") | ||
| assertEquals(parsed_event.requestHeaders(CIString("header")), "value") |
Member
There was a problem hiding this comment.
Sorry, one last comment (it applies to all of your PRs): instead of checking each field individually, could we construct an instance of the object and assert its equality like in the existing tests? I think this is a preferable approach because we can be confident we didn't forget to test any fields, etc.
armanbilge
changed the title
AppSyncLambdaAuthorizer
armanbilge
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#48 : adds AWS Lambda event type AppSynclambdaAuthorizer