Skip to content

Avoid allocations when calling Resource.liftK #4589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nmichael44 wants to merge 1 commit into
base: series/3.x
Choose a base branch
from
+6 −3
Open

Avoid allocations when calling Resource.liftK #4589

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions kernel/shared/src/main/scala/cats/effect/kernel/Resource.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -993,13 +993,16 @@ object Resource extends ResourceFOInstances0 with ResourceHOInstances0 with Reso
def onFinalizeCase[F[_]: Applicative](release: ExitCase => F[Unit]): Resource[F, Unit] =
unit.onFinalizeCase(release)

private val cachedLiftK: Id ~> Resource[Id, *] =
new (Id ~> Resource[Id, *]) {
def apply[A](fa: Id[A]): Resource[Id, A] = Resource.eval(fa)
}

/**
* Lifts an applicative into a resource as a `FunctionK`. The resource has a no-op release.
*/
def liftK[F[_]]: F ~> Resource[F, *] =
new (F ~> Resource[F, *]) {
def apply[A](fa: F[A]): Resource[F, A] = Resource.eval(fa)
}
cachedLiftK.asInstanceOf[F ~> Resource[F, *]]

/**
* Allocates two resources concurrently, and combines their results in a tuple.
Expand Down
Loading