Add ArbitraryDequeue to scalacheck module and wire ArbitraryTreeList#801
Open
krrishverma1805-web wants to merge 1 commit intotypelevel:masterfrom
Open
Add ArbitraryDequeue to scalacheck module and wire ArbitraryTreeList#801krrishverma1805-web wants to merge 1 commit intotypelevel:masterfrom
krrishverma1805-web wants to merge 1 commit intotypelevel:masterfrom
Conversation
Author
|
Hi @gemelen 👋 Would you have a chance to take a look at this when you get a moment? This PR addresses one of the items in TODO.md — moving arbitrary Happy to make any adjustments based on your feedback. Thanks! |
Member
|
Hi @krrishverma1805-web, before we look at your PR, would you mind making a contribution to our onboarding repository? Directions are in the README. |
Author
|
Hi @armanbilge , thanks for the pointer! I'll complete the onboarding and come back. 🙂 |
Author
|
I've completed the onboarding contribution: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
ArbitraryDequeueinstance to thecats-collections-scalacheckmodule, makingArbitrary[Dequeue[A]]available to downstream users.ArbitraryTreeListintoAllArbitraryand the package object, which was previously defined but not included.Why
The
TODO.mdnotes: "move arbitrary instances somewhere that one can import into other projects".Currently,
Arbitrary[Dequeue[A]]is only defined inline inDequeueSuiteand is not available to downstream library users who may want to write property-based tests involvingDequeue. This PR makes it available through the standard import paths: