Cache unchanged templates during IDE editing via TemplateContext#1093
Draft
johanrd wants to merge 1 commit intotyped-ember:mainfrom
Draft
Cache unchanged templates during IDE editing via TemplateContext#1093johanrd wants to merge 1 commit intotyped-ember:mainfrom
johanrd wants to merge 1 commit intotyped-ember:mainfrom
Conversation
When editing a .gts file, templates that haven't changed now skip both the @glimmer/syntax preprocess() parse and the full templateToTypescript() transform. Each template gets a persistent TemplateContext slot (held by VirtualGtsCode) that stores the last template string, AST, and transform result — one slot per template position, no unbounded growth. The CLI path is unaffected — no TemplateContext is passed, so all cache checks are skipped.
b482433 to
4450598
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TemplateContext, a per-template cache slot that persists acrossrewriteModule()callspreprocess()andtemplateToTypescript()are skipped entirelyVirtualGtsCodeholds aTemplateContext[]passed through the pipeline — one slot per template position, no unbounded growthBenchmarks
ts-template-imports-apptest app — JS edit (template unchanged)Playground.gtsGreeting.gtsaugmented.gtswith-declaration-consumer.gtscolocated/index.gtsSpeedup scales with template size. On a production app with larger templates on a M1 mac:
a.gtsb.gtsc.gtsd.gtsMemory
After 1000 keystrokes: 1 slot for a single-template file. No growth.
CLI (
ember-tsc)No
TemplateContextis passed in the CLI path — all cache checks are skipped. No regression.Test plan
.gtsfileember-tscCLI produces identical output