Gracefully turn off glint when no config at all is detected#1064
Merged
NullVoxPopuli merged 2 commits intomainfrom Mar 9, 2026
Merged
Gracefully turn off glint when no config at all is detected#1064NullVoxPopuli merged 2 commits intomainfrom
NullVoxPopuli merged 2 commits intomainfrom
Conversation
NullVoxPopuli
commented
Mar 6, 2026
| async function copyWasmFile() { | ||
| const sourceWasm = join( | ||
| __dirname, | ||
| '../../core/node_modules/content-tag/pkg/node/content_tag_bg.wasm', |
Contributor
Author
There was a problem hiding this comment.
leftover from the package rename
Contributor
|
Is this replacing #1052? Makes sense if we just get it so JS experience is not full of red squigglies then improve from there. |
Contributor
Author
|
It is not, but #1052 got too big, so I sort of wanted to do a progressive / incremental set of improvements to the JS experience when folks have Glint installed
exactly |
driesdl
approved these changes
Mar 9, 2026
wagenet
approved these changes
Mar 9, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is better than the error / add squiggles when no config is present behavior we have today.
In future PRs: