Make non-blocking moves actually non-blocking and fix rpm#21
Open
Smeat wants to merge 1 commit intotyhenry:masterfrom
Open
Make non-blocking moves actually non-blocking and fix rpm#21Smeat wants to merge 1 commit intotyhenry:masterfrom
Smeat wants to merge 1 commit intotyhenry:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By having the delay in the
seqfunction we also get a delay when calling therunmethod. Since we waited fordelayµs , and then setlastStepTimethe rpm was also halved.This adds a "blocking" parameter to the step methods with the default set to true to retain the old behaviour