Support for setting the service name

[perangel]

Problem

It would be useful to be able to specify the service name and not rely on the fullname (which requires using fullnameOverride to set).

While service.name is defined in the values.yaml, it is not referenced anywhere.

Proposed Solution

• Set the default value of service.name to "" and add an if/else conditional in the service template that will allow you to specify the service name.
• If unset, it will fallback to the existing behavior.

[perangel]

Alternatively, I think this could be written as:

Suggested change

	{{- if .Values.service.name }}
	name: {{ .Values.service.name }}
	{{- else }}
	name: {{ .Values.service.name | default template "docker-registry.fullname" . }}

[joshsizer]

This works with include instead of template, and some extra parens:

Suggested change

	{{- if .Values.service.name }}
	name: {{ .Values.service.name }}
	{{- else }}
	name: {{ .Values.service.name | default (include "docker-registry.fullname" .) }}

I found a nice reference about template vs. include here: https://stackoverflow.com/a/71091339

[joshsizer]

@perangel Nice catch, this is a much needed feature! I left a suggestion that I've tested locally and confirmed works for me.

If that suggestion looks good to you, please apply it and we can get this merged in 👍

Edit: we do also need to make that change anywhere the service name is referenced, for example from the ingress resource.

[joshsizer]

This works with include instead of template, and some extra parens:

Suggested change

	{{- if .Values.service.name }}
	name: {{ .Values.service.name }}
	{{- else }}
	name: {{ .Values.service.name | default (include "docker-registry.fullname" .) }}

I found a nice reference about template vs. include here: https://stackoverflow.com/a/71091339