Skip to content

Fix compilation for rustc > 1.80#119

Closed
picnoir wants to merge 2 commits into
twosigma:mainfrom
picnoir:pic/update-time
Closed

Fix compilation for rustc > 1.80#119
picnoir wants to merge 2 commits into
twosigma:mainfrom
picnoir:pic/update-time

Conversation

@picnoir

@picnoir picnoir commented Aug 6, 2024

Copy link
Copy Markdown
Contributor

Fix the build for rustc > 1.80.

Fix #118

@picnoir picnoir marked this pull request as draft August 6, 2024 09:52
@picnoir

picnoir commented Aug 6, 2024

Copy link
Copy Markdown
Contributor Author

Not good enough.

Bumping time to 0.3.36. Fix the build for rustc > 1.80.

Fix twosigma#118
We don't really use it for now, this is already encoded in the
addrlist. But let's keep this structure aligned with the glibc
counterpart.
@picnoir picnoir changed the title cargo.lock: bump time version Fix compilation for rustc > 1.80 Aug 6, 2024
@picnoir

picnoir commented Aug 6, 2024

Copy link
Copy Markdown
Contributor Author

Okay, this is ready.

I don't understand the Debian failure.

This is blocking for NixOS. See NixOS/nixpkgs#332176 for more details.

We should probably cut out a new release once this PR is ready and merged.

@picnoir picnoir marked this pull request as ready for review August 6, 2024 10:16
@leifwalsh

Copy link
Copy Markdown
Collaborator

I don't understand the Debian build failure either but it's been persistent. I'll ask someone who knows Debian more to take a look, I'd like to get this and #110 merged, as well as some of the dependabot things.

@leifwalsh

Copy link
Copy Markdown
Collaborator

We dealt with this in #123

@leifwalsh leifwalsh closed this Oct 3, 2024
@picnoir picnoir deleted the pic/update-time branch October 4, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't build on Rustc > 1.80

2 participants