Fix verification bug: only verify modified pages#36
Open
sijk wants to merge 1 commit intotwinearthsoftware:masterfrom
Open
Fix verification bug: only verify modified pages#36sijk wants to merge 1 commit intotwinearthsoftware:masterfrom
sijk wants to merge 1 commit intotwinearthsoftware:masterfrom
Conversation
|
This commit solved the verification problem that I'm was having. Checking only the modified bytes is the right approach. Thank you for the fix, your pull request should be accepted as soon as possible. |
|
when you are uploading the hex file ensure you are not using the file that contains the bootloader. this will cause verification to fail. (using the non bootloader file will not delete your bootloader if you have one) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the same check in VerifyProgram() as in ProgramDevice() so that only those pages that were written to are read back for verification.
For example, I write a table of constants to the end of flash and without this fix it tries to verify all flash, even though it only wrote the last couple of pages.