-
Notifications
You must be signed in to change notification settings - Fork 5
feat(voice): per-call TwiML overrides for custom hosts (host_twiml_options + websocket_url) #75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
d537855
feat(voice): allow per-call websocket_url override on handle_incoming…
ryanrouleau fe62b28
refactor(voice): route per-call websocket_url through TwiMLOptions, n…
ryanrouleau 50069cd
feat(voice): add server_twiml_options layer + let generate_twiml read…
ryanrouleau 569aba0
docs(voice): trim redundant comments on server_twiml_options / genera…
ryanrouleau 4668531
fix(voice): generate_twiml must emit the resolved URL, not the raw po…
ryanrouleau 2207f59
refactor(voice): rename server_twiml_options → host_twiml_options
ryanrouleau cb8bc45
chore: bump version to 2.1.0
ryanrouleau 146ebd4
fix(voice): address PR review — stale docs + empty websocket_url hand…
ryanrouleau c2fac3b
fix(voice): default_twiml_options now outranks host_twiml_options
ryanrouleau File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we have two functions for this, one is for taking twiml_request, another is for taking host_twiml_options? i assume users will only choose one way to make it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They're two complimentary but different args:
twiml_requestis the server agnostic representation of the initial Twiml request from Twilio, handle_incoming_call then generates the twiml response internallyhost_twiml_optionsallows the server to inject specific twiml options/attributes into that generation. This enables our deployments where for example we need to add?session=<conversationId / callSid>for session affinity in the websocket URL for Foundry hosted agents or agentcoreThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated the docstring to make this clearer