Skip to content

Fix performance issue in Wikifier.parse #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dmchurch wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix performance issue in Wikifier.parse #190

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions targets/engine.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1488,14 +1488,18 @@ Wikifier.prototype.fullArgs = function (includeName) {

Wikifier.parse = function (input) {
var m, re, b = input, found = [],
g = Wikifier.textPrimitives.unquoted;
qstrings = [], qreg = /'[^'\\]*(?:\\.[^'\\]*)*'|"[^"\\]*(?:\\.[^"\\]*)*"/g,
preg = /\x00QSTR.(\d+)\x00/g;;

// Extract all the quoted strings and save them for later
b = b.replace(qreg, function(qstr) {qstrings.push(qstr); return "\x00QSTR."+(qstrings.length-1)+"\x00"});

function alter(from,to) {
b = b.replace(new RegExp(from+g,"gim"),to);
b = b.replace(new RegExp(from,"gim"),to);
return alter;
}
// Extract all the variables, and set them to 0 if undefined.
re = new RegExp(Wikifier.textPrimitives.variable+g,"gi");
re = new RegExp(Wikifier.textPrimitives.variable,"gi");
while (m = re.exec(input)) {
if (!~found.indexOf(m[0])) {
// This deliberately contains a 'null or undefined' check
Expand All @@ -1517,6 +1521,9 @@ Wikifier.parse = function (input) {
// New operators
("\\bis\\b", " == ")
("\\bto\\b", " = ");

// Restore all the quoted strings to their place
b = b.replace(preg, function(pstr, qidx) {return qstrings[qidx];});
return b
};
Wikifier.formatHelpers = {
Expand Down