Remove calls to resolve_tools#2406
Draft
iteratee wants to merge 9 commits into
Draft
Conversation
iteratee
force-pushed
the
kb/bazel86
branch
7 times, most recently
from
a9ff57d to
d63c0fe
Compare
Replace them mostly with `FilesToRunProvider`s. For cc_wrapper, where repl's also need the runfiles, use a struct that has the executable, the `FilesToRunProvider` and the runfiles. The executable could be retrieved from the `FilesToRunProvider`, but it is more convenient to just have it in the struct. Remove outdated comment about re-enabling resolve_tools for bazel 8
The inherited RUNFILES_* environment variables aren't correct. Pass in a path to try and find the correct directory/manifest. Only prints currently.
Make sure that the runfiles for cc_wrapper are included in the runfiles for ghc_wrapper
This will allow the CC_* env vars to reach cc_wrapper if it is invoked during hsc2hs's run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace them mostly with
FilesToRunProviders. Forcc_wrapper, where repl's also need the runfiles, use a struct that has the executable, theFilesToRunProviderand the runfiles. The executable could be retrieved from theFilesToRunProvider, but it is more convenient to just have it in the struct.Remove outdated comment about re-enabling resolve_tools for bazel 8