Skip to content

Fix aria-pressed initialization for toggle buttons #42466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
puneetdixit200 wants to merge 1 commit into
base: main
Choose a base branch
from
+24 −0
Open

Fix aria-pressed initialization for toggle buttons #42466

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions js/src/button.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,16 @@ const EVENT_CLICK_DATA_API = `click${EVENT_KEY}${DATA_API_KEY}`
*/

class Button extends BaseComponent {
constructor(element) {
super(element)

if (!this._element || this._element.hasAttribute('aria-pressed')) {
return
}

this._element.setAttribute('aria-pressed', this._element.classList.contains(CLASS_NAME_ACTIVE))
}

// Getters
static get NAME() {
return NAME
Expand Down
14 changes: 14 additions & 0 deletions js/tests/unit/button.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,20 @@ describe('Button', () => {
expect(buttonByElement._element).toEqual(buttonEl)
})

it('should initialize aria-pressed when missing', () => {
fixtureEl.innerHTML = [
'<button class="btn" data-bs-toggle="button"></button>',
'<button class="btn active" data-bs-toggle="button"></button>'
].join('')

const buttons = fixtureEl.querySelectorAll('[data-bs-toggle="button"]')
const buttonInstances = [...buttons].map(button => new Button(button))

expect(buttonInstances).toHaveSize(2)
expect(buttons[0].getAttribute('aria-pressed')).toEqual('false')
expect(buttons[1].getAttribute('aria-pressed')).toEqual('true')
})

describe('VERSION', () => {
it('should return plugin version', () => {
expect(Button.VERSION).toEqual(jasmine.any(String))
Expand Down