Small fixes: remove redundant code and deduplicate defaults#30
Merged
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
evictEmbeddingCache was identical to invalidateEmbeddingCache. Replace all usages with invalidateEmbeddingCache and remove the duplicate. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
putEmbeddings and deleteEmbeddings already call invalidateEmbeddingCache internally, so the explicit call at the end of indexBlocks was unnecessary. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The default values for each setting were specified both in settingsSchema and in getSettings(). Now getSettings() derives its defaults from the schema, so each default is defined in one place. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The getCurrentGraph/setGraphName pattern was repeated in both the auto-index-on-load and graph-change handlers. Extract it into a shared helper function. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
evictEmbeddingCachefunction (identical toinvalidateEmbeddingCache)invalidateEmbeddingCache()call at end ofindexBlocks(already called internally byputEmbeddings/deleteEmbeddings)getSettings()syncGraphNamehelper to deduplicate graph name fetch pattern inmain.tsTest plan
🤖 Generated with Claude Code