Skip to content

update linux instructions in README.md #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dstathis wants to merge 1 commit into from
Closed

update linux instructions in README.md #127

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,9 +66,17 @@ sudo apt install libboost-dev libwxgtk3.0-gtk3-dev libhunspell-dev
````
Then use cmake to build
````
cmake build -DCMAKE_BUILD_TYPE=Release
cmake --build build
mkdir build
cd build
cmake ..
make
Copy link

@mattiasb mattiasb Apr 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of this you can just do:

$ cmake -Bbuild -DCMAKE_BUILD_TYPE=Release
$ cmake --build build

This is better for two reasons:

  1. It's shorter. :)
  2. It doesn't assume you're using make over ninja.

Copy link

@mattiasb mattiasb Apr 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some fixes to README.md in #131 that does the above btw.

Copy link
Author

@dstathis dstathis Apr 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rewrote those steps because they did not work on linux. Can't remember now why though

Copy link

@mattiasb mattiasb Apr 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's because the original steps assumes there's already a build directory present. :)

````
Before running you must copy the resource directory
````
mkdir ~/.magicseteditor
cp -r resource ~/.magicseteditor/
````
Then you need to get data files. The most commonly used data files can be found [here](https://github.com/CajunAvenger/Cajun-Style-Templates/)
Use `CMAKE_BUILD_TYPE=Debug` for a debug build

## Building on Mac
Expand Down