Open
Conversation
There is a memory leak in the AsyncClient. The SSL part is not freed by the destructor. My opinion is that it is caused by _lwip_fin where we have _pcb = NULL; but when we want to delete ssl part by int tcp_ssl_free(struct tcp_pcb *tcp) it takes +pcb as an argument but it is NULL... I think this as the simplest solution.
Author
|
The SSL part is not freed by the destructor when _pcb is NULL. |
Author
|
There is also possibility to remove the old version of tcp_ssl_free at all and use modified version with argument this instead of _pcb everywhere. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have found that there is a memory leak in the secure part of the AsyncClient.
The problem can be seen simply when you create new AsyncClient by new, then connect to some secure server and then try to dealocate by delete. This will left about 40kB of memory somewhere.
This patch may solve it. Hope it helps.