Allow initializing pool without a buildroot & other minor cleanup #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OnGle
suggested changes
Dec 22, 2025
| strict: bool = False, | ||
| quiet: bool = False, | ||
| tree: bool = False, | ||
| preserve_buildroot: str | None = None, |
Member
There was a problem hiding this comment.
With this setting the deckdebuild env-vars and conf relating to buildroot preservation are never read. This was set to None specifically to ensure this does not happen.
Member
Author
There was a problem hiding this comment.
Doh! 🤦♂️ Great catch!
I'll wind that back and assuming it "just works" I'll merge this...
Change function name to reflect what it does.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the title, the primary purpose of this PR is to support creation of a pool without a buildroot (e.g. if you only need a pool with stocks of pools and/or directories of prebuilt packages). That is achevied in these 2 commits:
Plus there are some other minor modifications:
Bugfix:
Improvement:
pool-...commands fail: d9925b2Other general code tiding:
preserve_buildroot="on-error"' as default inpool_get()func inpool_bin`: 76b0c0f