-
Notifications
You must be signed in to change notification settings - Fork 3
Feature/pattern change detection #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…, STPH) with real-time GUI dashboard
…, STPH) with real-time GUI dashboard
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are several points that need to be fixed before merging.
Several things mentioned under https://github.com/tuda-parallel/FTIO/blob/feature/pattern_change_detection/docs/students_contribute.md are missing. This includes:
- Documentation and license for new files: https://github.com/tuda-parallel/FTIO/blob/feature/pattern_change_detection/docs/students_contribute.md#-module-documentation-and-licensing
- Adding test cases: https://github.com/tuda-parallel/FTIO/blob/feature/pattern_change_detection/docs/students_contribute.md#-module-documentation-and-licensing
- Adding a documentation: https://github.com/tuda-parallel/FTIO/blob/feature/pattern_change_detection/docs/students_contribute.md#-module-documentation-and-licensing
A-Tarraf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some open ToDos
|
It looks much better! Thank you for your changes. Could you just maybe:
|
A-Tarraf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only small function documentation are missing now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work, well done!
A-Tarraf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, thank you!
Implementation of the three adaptive change point detection algorithms with a real-time visualization dashboard.
Algorithms: ADWIN, AV-CUSUM, STPH