Fix yellow warning about requiresMainQueueSetup on iOS#8
Open
kimklai wants to merge 3 commits intotuanpmt:masterfrom
Open
Fix yellow warning about requiresMainQueueSetup on iOS#8kimklai wants to merge 3 commits intotuanpmt:masterfrom
kimklai wants to merge 3 commits intotuanpmt:masterfrom
Conversation
- fix the yellow warning on ios simulator Module Smartconfig requires main queue setup since it overrides `init` but doesn't implement `requiresMainQueueSetup`. In a future release React Native will default to initializing all native modules on a background thread unless explicitly opted-out of.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Issue #7
Module Smartconfig requires main queue setup
since it overrides
initbut doesn't implementrequiresMainQueueSetup.In a future release React Native will default to initializing
all native modules on a background thread unless explicitly opted-out of.