Update DistanceCalculator.py #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the function distanceCalculator calls the function createPath, it passes the coordinates in the format (longitude, latitude). But while creating the indices on path, the function route_through_array again takes the input in reversed format. Hence the returned indices are in the format (latitude_index, longitude_index) which is then converted to (latitudes,longitudes). And this is returned from createPath. So when distanceCalculator calls calculateDistance, it is actually passing the coordinates in (Latitude, Longitudes) order. Hence there is not need to reverse that order while calculating distance. The edit in the test case is just to make the stopCoord latitude be fetched from the same port entry as its longitude. It was mistakenly written as ports.latitude[100] when it should have been ports.latitude[1000].
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the function distanceCalculator calls the function createPath, it passes the coordinates in the format (longitude, latitude). But while creating the indices on path, the function route_through_array again takes the input in reversed format. Hence the returned indices are in the format (latitude_index, longitude_index) which is then converted to (latitudes,longitudes). And this is returned from createPath. So when distanceCalculator calls calculateDistance, it is actually passing the coordinates in (Latitude, Longitudes) order. Hence there is not need to reverse that order while calculating distance.
The edit in the test case is just to make the stopCoord latitude be fetched from the same port entry as its longitude. It was mistakenly written as ports.latitude[100] when it should have been ports.latitude[1000].