Change regex for recognizing errors in the syslog format#824
Open
rzadp wants to merge 1 commit intotstack:masterfrom
Open
Change regex for recognizing errors in the syslog format#824rzadp wants to merge 1 commit intotstack:masterfrom
rzadp wants to merge 1 commit intotstack:masterfrom
Conversation
Contributor
|
This would result in a huge number of false positives since many messages that are not errors contain the string I suggest not merging this as-is (and instead use overrides like documented in https://docs.lnav.org/en/latest/formats.html, #1113 improves the docs a bit). For me this would result in false positives for all messages containing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have found that
erris used as an alias toerror.Changing the regex to catch
errwould work for both usages.