Merged
Conversation
- Verifies that StatusCode.random returns an int as well as StatusCode
and docs - Update issue template headings from `####` to `##` and `###` for proper hierarchy - Add markdown titles to pull request template and MCP prompt files - Fix minor formatting inconsistencies in CHANGELOG.md and code of conduct - Improve markdown structure consistency across documentation
- Replace VS Code tasks with Zed editor support (.vscode/ → .zed/) - Add .vscode/ to .gitignore for local editor settings - Update .pubignore to exclude Zed configuration instead of VS Code - Bump Dart SDK minimum version from 3.11.0 to 3.11.1 in example - Add CodeRabbit PR review badge to README - Fix trailing newlines in configuration files - Update CHANGELOG with new badge documentation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
added
the
documentation
Contributor
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThis PR standardizes issue template header formatting, migrates editor configuration from VSCode to Zed, updates project documentation and metadata, and adds test assertions for StatusCode.random functionality. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested labels
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. 📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #125 +/- ##
=======================================
Coverage 99.57% 99.57%
=======================================
Files 3 3
Lines 1397 1397
=======================================
Hits 1391 1391
Misses 6 6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 3
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
extension/mcp/prompts/cache_strategy.md (2)
35-42:⚠️ Potential issue | 🟠 MajorEnsure TTL behavior is deterministic for all cacheable codes.
Line 35–42 maps only part of the RFC cacheable set, but Line 46–47 instructs storing whenever
isCacheableis true. For cacheable codes not mapped (e.g., 203/206/300/405/414),ttlcan benull, which makes retention behavior backend-dependent and potentially too long.Suggested patch
- final ttl = rawStatusCode.toRegisteredStatusCode()?.whenConstOrNull( - okHttp200: Duration(minutes: 5), - noContentHttp204: Duration(minutes: 1), - notFoundHttp404: Duration(minutes: 10), - movedPermanentlyHttp301: Duration(days: 1), - goneHttp410: Duration(hours: 1), - notImplementedHttp501: Duration(hours: 6), - ); + final ttl = rawStatusCode.toRegisteredStatusCode()?.whenConstOrNull( + okHttp200: Duration(minutes: 5), + nonAuthoritativeInformationHttp203: Duration(minutes: 2), + noContentHttp204: Duration(minutes: 1), + partialContentHttp206: Duration(minutes: 2), + multipleChoicesHttp300: Duration(minutes: 10), + movedPermanentlyHttp301: Duration(days: 1), + notFoundHttp404: Duration(minutes: 10), + methodNotAllowedHttp405: Duration(minutes: 30), + goneHttp410: Duration(hours: 1), + uriTooLongHttp414: Duration(minutes: 30), + notImplementedHttp501: Duration(hours: 6), + ) ?? + const Duration(minutes: 5); // conservative fallbackAlso applies to: 46-47, 52-53
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@extension/mcp/prompts/cache_strategy.md` around lines 35 - 42, The TTL mapping for rawStatusCode via toRegisteredStatusCode()?.whenConstOrNull only covers some cacheable status codes, so when isCacheable is true ttl can be null and retention becomes backend-dependent; update the ttl computation (the code that assigns ttl from toRegisteredStatusCode() / whenConstOrNull) to include all RFC-defined cacheable status codes (e.g., 203, 206, 300, 405, 414, etc.) with explicit Duration values and add a deterministic fallback Duration (or explicit non-cache action) for any remaining registered codes so that downstream logic that checks isCacheable and uses ttl always has a non-null, predictable TTL. Ensure you modify the same ttl variable and related logic that relies on isCacheable to use the new explicit mapping or fallback.
52-52:⚠️ Potential issue | 🟡 MinorRemove unverified performance claim from the prompt text.
Line 52 states "no runtime allocations," but the
functional_status_codeslibrary does not document allocation behavior fortoRegisteredStatusCode()orwhenConstOrNull, and Dart does not provide official allocation guarantees for this pattern. Replace the parenthetical comment with a neutral statement (e.g., "these methods are onStatusCode, not rawint") or remove the performance claim entirely.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@extension/mcp/prompts/cache_strategy.md` at line 52, Update the prompt text to remove the unverified performance claim; replace the parenthetical "(no runtime allocations)" with a neutral note such as "these methods are on `StatusCode`, not raw `int`" (or remove it entirely) so the line referencing `toRegisteredStatusCode()` and `whenConstOrNull(...)` only states that the conversion is necessary because those methods exist on `StatusCode` rather than asserting allocation behavior.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/ISSUE_TEMPLATE/performance.md:
- Line 10: Edit the guidance sentence in the performance template to fix
grammar: change "Bonus point's if you can tie this directly to user experience."
to "Bonus points if you can tie this directly to user experience." and replace
"what the performance impact is going to be." with "what the performance impact
will be." so the full sentence reads clearly and grammatically.
In @.github/ISSUE_TEMPLATE/refactor.md:
- Line 10: Fix the typo in the issue template sentence "Clearly describe what
needs to be refactored any why." by changing "any why" to "and why" so the
sentence reads "Clearly describe what needs to be refactored and why."; locate
the exact line containing that sentence in the refactor issue template and
update the copy accordingly to preserve user-facing wording.
In @.zed/debug.json:
- Line 9: Remove the trailing commas in the JSON object/array entries so the
file is valid JSON: locate the dangling commas shown as "}," in .zed/debug.json
(they appear after the last property in objects at the end of the blocks) and
delete those trailing commas so the final element in each object/array is not
followed by a comma, then validate the file with a JSON parser.
---
Outside diff comments:
In `@extension/mcp/prompts/cache_strategy.md`:
- Around line 35-42: The TTL mapping for rawStatusCode via
toRegisteredStatusCode()?.whenConstOrNull only covers some cacheable status
codes, so when isCacheable is true ttl can be null and retention becomes
backend-dependent; update the ttl computation (the code that assigns ttl from
toRegisteredStatusCode() / whenConstOrNull) to include all RFC-defined cacheable
status codes (e.g., 203, 206, 300, 405, 414, etc.) with explicit Duration values
and add a deterministic fallback Duration (or explicit non-cache action) for any
remaining registered codes so that downstream logic that checks isCacheable and
uses ttl always has a non-null, predictable TTL. Ensure you modify the same ttl
variable and related logic that relies on isCacheable to use the new explicit
mapping or fallback.
- Line 52: Update the prompt text to remove the unverified performance claim;
replace the parenthetical "(no runtime allocations)" with a neutral note such as
"these methods are on `StatusCode`, not raw `int`" (or remove it entirely) so
the line referencing `toRegisteredStatusCode()` and `whenConstOrNull(...)` only
states that the conversion is necessary because those methods exist on
`StatusCode` rather than asserting allocation behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 4c4080a3-155a-4dc0-9c20-3fd74a6d466f
📒 Files selected for processing (25)
.github/ISSUE_TEMPLATE/bug_report.md.github/ISSUE_TEMPLATE/build.md.github/ISSUE_TEMPLATE/chore.md.github/ISSUE_TEMPLATE/ci.md.github/ISSUE_TEMPLATE/documentation.md.github/ISSUE_TEMPLATE/feature_request.md.github/ISSUE_TEMPLATE/performance.md.github/ISSUE_TEMPLATE/refactor.md.github/ISSUE_TEMPLATE/revert.md.github/ISSUE_TEMPLATE/style.md.github/ISSUE_TEMPLATE/test.md.github/code_of_conduct.md.github/dependabot.yaml.github/pull_request_template.md.gitignore.pubignore.vscode/tasks.json.zed/debug.jsonCHANGELOG.mdREADME.mdexample/pubspec.yamlextension/mcp/prompts/cache_strategy.mdextension/mcp/prompts/handle_response.mdpubspec.yamltest/src/status_code_test.dart
💤 Files with no reviewable changes (1)
- .vscode/tasks.json
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
- Remove trailing comma from first debug configuration - Remove trailing comma from second debug configuration - Ensure valid JSON syntax
tsinis
dismissed stale reviews from coderabbitai[bot] and github-actions[bot]
via
4173e99
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Migrated to Zed (from VS Code), added CodeRabbit.AI badge. Fixed a lot of MD files.
Type of Change
Summary by CodeRabbit
Documentation
Chores
Tests