feat: add types: ["node"] to all node tsconfig bases#353
Open
RobinBol wants to merge 1 commit intotsconfig:mainfrom
Open
feat: add types: ["node"] to all node tsconfig bases#353RobinBol wants to merge 1 commit intotsconfig:mainfrom
RobinBol wants to merge 1 commit intotsconfig:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"types": ["node"]to allnodeXXandnode-ltsbase configstypes: ["node"]to tsconfig #351 - TypeScript 6/7 changestypesdefault fromundefined(include all@types/*) to[](include none)Backwards compatibility note
Setting
types: ["node"]explicitly is not fully backwards compatible for TS5 users. Previously, withtypesunset, TypeScript auto-included all@types/*packages fromnode_modules(e.g.@types/jest,@types/react). With this change, only@types/nodeis included. Users relying on other@types/*packages will need to add them to their owntypesarray.I've left versioning as-is for maintainers to decide on the appropriate bump (minor vs major).