feat: auto-wrap plain object route returns in Response.json()#49
Open
CelebrityPunks wants to merge 1 commit intotscircuit:mainfrom
Open
feat: auto-wrap plain object route returns in Response.json()#49CelebrityPunks wants to merge 1 commit intotscircuit:mainfrom
CelebrityPunks wants to merge 1 commit intotscircuit:mainfrom
Conversation
Instead of throwing when a route returns a plain object, auto-wrap it in Response.json() for developer convenience. Closes tscircuit#30 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
CelebrityPunks
requested review from
ShiboSoftwareDev and
seveibar
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a route returns a plain object (
return { foo: "bar" }) instead ofResponse.json(...), winterspec now auto-wraps it inResponse.json()instead of throwing an error. This makes route handlers more convenient.Changes
src/middleware/with-response-object-check.ts: Changed from throwing error to returningResponse.json(rawResponse)tests/errors/do-not-allow-raw-json.test.ts: Updated test to verify auto-wrapping behaviorCloses #30
🤖 Generated with Claude Code