fix: prevent duplicate pin indicators by deduplicating primitives by element#697
Open
techmannih wants to merge 5 commits intotscircuit:mainfrom
Open
fix: prevent duplicate pin indicators by deduplicating primitives by element#697techmannih wants to merge 5 commits intotscircuit:mainfrom
techmannih wants to merge 5 commits intotscircuit:mainfrom
Conversation
techmannih
requested review from
Abse2001,
ShiboSoftwareDev and
seveibar
as code owners
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Member
Author
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1eb5b92895
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://discord.com/channels/1233487248129921135/1265314333764878387/1481533515240570960
This PR fixes a bug where hovering over plated holes or complex pads would cause the pin indicator text and red overlay box to appear twice. This occurred because the viewer rendered an overlay for every primitive associated with a pin (e.g., both the copper pad and the drill hole).
Changes
Primitive Deduplication: Updated ElementOverlayBox to deduplicate highlighted primitives by their parent
_element. This ensures each physical pin or component element gets exactly one overlay box and label, regardless of its internal primitive count.Expanded Hover Priority: Included
pcb_plated_holein the logic that prioritizes pins over traces. When hovering over a plated hole that overlaps with a trace, the pin indicator now correctly takes precedence.test https://pcb-viewer-bpoaupbkv-tscircuit.vercel.app/?fixture=%7B%22path%22%3A%22src%2Fexamples%2F2026%2Fplated_hole_hover_fix.fixture.tsx%22%7D