feat: now pads on Hover show offset#529
Conversation
Quanta-Naut
requested review from
ShiboSoftwareDev and
seveibar
as code owners
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Recording.2025-12-10.190834.mp4 |
|
@imrishabh18 Please review it. |
imrishabh18
left a comment
imrishabh18
left a comment
There was a problem hiding this comment.
I don't see the offset hover though in the preview
@imrishabh18 You will have to toggle the "show offset" under view, I have changed it to true by default |
|
@seveibar Review it please. |
seveibar
left a comment
seveibar
left a comment
There was a problem hiding this comment.
You're showing the pad offset, which is an OK feature but not the original issue. We want to show COMPONENT offsets, i.e. component offsets from the parent group. It is similar to the feature for showing group anchors
this feature is interesting but i'm not sure it's useful since generally people position components not individual elements of a footprint unless they're doing footprint design, which is sort of a different thing
seveibar
left a comment
seveibar
left a comment
There was a problem hiding this comment.
some unrelated changes? please reduce to only related changes.
anchor offset should always show or show-by-default with a view menu option to disable (i.e. "Anchor Offsets on Hover")
…offset (default to true)
seveibar
left a comment
seveibar
left a comment
There was a problem hiding this comment.
see comment
I was disappointed to see you removed the option to show all the group anchors
| /> | ||
| <CheckboxMenuItem | ||
| label="Show Group Anchor Offsets" | ||
| label="Anchor Offsets on Hover" |
There was a problem hiding this comment.
both these options should be available, they do different things
4 participants
Sorry for the delay (it's been almost 1.5 months before since I started working on this issue, sorry) had college work.
I have added the offset (x, y) to the pads on hover.
Also deleted the previous PR, messed it up with conflicts.
The attached video is the demo.
Fixes: #409