Skip to content

Fix objectLimit across filtered graphics objects#217

Open
mercanet wants to merge 1 commit into
tscircuit:mainfrom
mercanet:codex-graphics-debug-object-limit
Open

Fix objectLimit across filtered graphics objects#217
mercanet wants to merge 1 commit into
tscircuit:mainfrom
mercanet:codex-graphics-debug-object-limit

Conversation

@mercanet
Copy link
Copy Markdown

@mercanet mercanet commented May 16, 2026

Fixes #42

/claim #42

Summary

  • Applies objectLimit globally across all filtered graphics objects instead of once per object type.
  • Counts objects before limiting so the warning reports the real filtered total.
  • Adds coverage for global limiting, no-limit pass-through, and zero limit.

Demo

objectLimit demo

Validation

  • npx tsc --noEmit
  • npx biome check site/components/InteractiveGraphics/InteractiveGraphics.tsx site/components/InteractiveGraphics/apply-object-limit.ts tests/apply-object-limit.test.ts
  • npm run build

@vercel
Copy link
Copy Markdown

vercel Bot commented May 16, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
graphics-debug Ready Ready Preview, Comment May 16, 2026 5:21am

Request Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add option objectLimit that limits the number of objects displayed (after filters) on InteractiveGraphics

1 participant