Update SVG snapshot for SOIC-20 footprint alignment analysis with improved dimensions and fill rules#519
Update SVG snapshot for SOIC-20 footprint alignment analysis with improved dimensions and fill rules#519rushabhcodes wants to merge 3 commits intotscircuit:mainfrom
Conversation
…roved dimensions and fill rules
|
Tests failing |
There was a problem hiding this comment.
Pull request overview
This PR updates the SOIC footprint generator to better match KiCad geometry by revising default pad dimensions/placement math, and refreshes SVG snapshot outputs accordingly.
Changes:
- Adjust SOIC default pad dimensions (
pw/pl) and proportional fallback calculations. - Tweak SOIC leg offset and silkscreen width calculations for improved alignment accuracy.
- Update snapshot SVGs for SOIC-20 / SOIC-8 / SOIC-28 parity and rendering diffs.
Reviewed changes
Copilot reviewed 1 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/fn/soic.ts | Updates SOIC parameter defaults, coordinate math, silkscreen sizing, and element typing. |
| tests/kicad-parity/snapshots/soic20_boolean_difference.snap.svg | Updates alignment-analysis SVG snapshot to reflect new geometry/rendering. |
| tests/kicad-parity/snapshots/soic20.snap.svg | Updates KiCad parity snapshot to reflect new SOIC-20 geometry. |
| tests/snapshots/soic8.snap.svg | Updates SOIC-8 snapshot for new default pad sizing/placement. |
| tests/snapshots/soic8_w5.3mm_p1.27mm.snap.svg | Updates SOIC-8 (explicit w/p) snapshot for new geometry. |
| tests/snapshots/soic8_pw04_pl1_pillpads.snap.svg | Updates SOIC-8 pill-pad snapshot for new geometry. |
| tests/snapshots/soic28_pw0762_pl1524.snap.svg | Updates SOIC-28 snapshot for new geometry. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ut adjustments and alignment improvements
techmannih
left a comment
There was a problem hiding this comment.
You need to add parity test for all which snapshot are changed.
… for alignment accuracy
|
Hi @rushabhcodes! I noticed the review comment requesting parity tests for all changed snapshots. Looking at the PR changes, the following snapshots were modified but don't have corresponding parity tests:
The existing Happy to help if you need assistance identifying the correct KiCad files! |
This pull request updates the SOIC (Small Outline Integrated Circuit) footprint generation logic to use more accurate default pad dimensions and improves type consistency throughout the code. The most important changes are:
Default SOIC pad dimensions and calculation logic:
pw) from 0.6mm to 0.65mm and pad length (pl) from 1.0mm to 1.67mm in both the schema defaults and the fallback logic. Adjusted the proportional calculations for missing values to match the new defaults. [1] [2]getCcwSoicCoordsto add/subtract 0.23mm, improving the placement accuracy of the SOIC legs.Type consistency and naming:
AnySoupElementwithAnyCircuitElementin function signatures and return types for better semantic clarity and consistency with the rest of the codebase. [1] [2] [3]pillpadandrectpadfunctions.