Karen's changes to picoquant file parsing code to enable ptu parsing #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(the new file format for Hydraharp 3.0 as of 2017)
Owner
|
A few changes to make:
|
Author
|
Sorry Thomas, I've been super busy but I will get around to this...perhaps
not for a little while, though.
…On Sat, Jul 15, 2017 at 11:15 AM, Thomas Bischof ***@***.***> wrote:
A few changes to make:
1. This commit introduces ncurses and windows as dependencies. Please
refactor to eliminate these requirements
2. Several files contain comments and unused code which do not add
clarity. Please delete these.
3. What is the scope of these changes? It looks like this commit
introduces support for HydraHarp PTU T2 files? Are any other formats
supported?
4. File formats supported by this change should be added to the --help
documentation.
5. Some of this code appears to be directly pulled from other
projects. What is the licensing of those projects?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AP9kyMy5yuVfVqRPYmkf4WZfLjfMiWoBks5sONeIgaJpZM4OUYdn>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(the new file format for Hydraharp 3.0 as of 2017)