feat(ecmascript): PlainTime.prototype.round#988
Open
0Zeno wants to merge 1 commit intotrynova:mainfrom
Open
Conversation
aapoalas
reviewed
Apr 24, 2026
| // 14. Let result be RoundTime(plainTime.[[Time]], roundingIncrement, smallestUnit, roundingMode). | ||
| let result = plain_time | ||
| .get(agent) | ||
| .inner_plain_time(agent) |
Member
There was a problem hiding this comment.
nitpick: You could get this before all the reborrow work and store it on the stack where it cannot be GC'd and is safe: that'd mean probably no need to scope plain_time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.