feat(ecmascript): PlainTime.prototype.toJSON#984
Open
jesperkha wants to merge 2 commits intotrynova:mainfrom
Open
feat(ecmascript): PlainTime.prototype.toJSON#984jesperkha wants to merge 2 commits intotrynova:mainfrom
jesperkha wants to merge 2 commits intotrynova:mainfrom
Conversation
jesperkha
changed the title
jesperkha
force-pushed
the
temporal/plaintime-toJson
branch
from
861dafa to
ab7ac1d
Compare
aapoalas
reviewed
Apr 24, 2026
aapoalas
previously approved these changes
Apr 24, 2026
Member
aapoalas
left a comment
aapoalas
left a comment
There was a problem hiding this comment.
LGTM but fixing the nitpick would maybe be a nice cleanup: you can get rid of all the unbinds as well that way.
aapoalas
force-pushed
the
temporal/plaintime-toJson
branch
from
ab7ac1d to
ecb6fe5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.