⚡ Bolt: fix: KeystoreInterceptor safety test failure and bump version#726
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
What:
Replaced the
ProcessBuilderstring injection call inKeystoreInterceptor.ktwithRuntime.getRuntime().exec(arrayOf(...))and properly drained bothinputStreamanderrorStream. Also bumped the module patch version toV2.3.5.Why:
The previous implementation violated safety rules detected by
KeystoreInterceptorSafetyTest, specifically the risk of shell injection and file descriptor (FD) exhaustion on the daemon. These issues were causing test suite failures on the CI pipeline. Reverting toarrayOfprevents shell evaluation, and reading streams reliably prevents deadlocks and FD leaks.Measured Improvement:
N/A - the goal of this PR is to resolve broken test failures (specifically
KeystoreInterceptorSafetyTest), rather than to improve performance metrics.PR created automatically by Jules for task 15990569357383624632 started by @tryigit