Skip to content

⚡ Bolt: fix: KeystoreInterceptor safety test failure and bump version#726

Merged
tryigit merged 1 commit into
masterfrom
jules-15990569357383624632-41d50cf3
Jun 4, 2026
Merged

⚡ Bolt: fix: KeystoreInterceptor safety test failure and bump version#726
tryigit merged 1 commit into
masterfrom
jules-15990569357383624632-41d50cf3

Conversation

@tryigit
Copy link
Copy Markdown
Owner

@tryigit tryigit commented Jun 3, 2026

What:
Replaced the ProcessBuilder string injection call in KeystoreInterceptor.kt with Runtime.getRuntime().exec(arrayOf(...)) and properly drained both inputStream and errorStream. Also bumped the module patch version to V2.3.5.

Why:
The previous implementation violated safety rules detected by KeystoreInterceptorSafetyTest, specifically the risk of shell injection and file descriptor (FD) exhaustion on the daemon. These issues were causing test suite failures on the CI pipeline. Reverting to arrayOf prevents shell evaluation, and reading streams reliably prevents deadlocks and FD leaks.

Measured Improvement:
N/A - the goal of this PR is to resolve broken test failures (specifically KeystoreInterceptorSafetyTest), rather than to improve performance metrics.


PR created automatically by Jules for task 15990569357383624632 started by @tryigit

@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@tryigit tryigit merged commit 6d15d2d into master Jun 4, 2026
10 checks passed
@tryigit tryigit deleted the jules-15990569357383624632-41d50cf3 branch June 4, 2026 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant